Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(invalid-dependency): add invalidAsyncFunction which rejects with an Error #1719

Merged
merged 9 commits into from
Dec 1, 2020
Merged

feat(invalid-dependency): add invalidAsyncFunction which rejects with an Error #1719

merged 9 commits into from
Dec 1, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 25, 2020

Issue #, if available:
Fixes: #1717

Description of changes:

  • Adds invalidAsyncFunction which rejects with an Error.
  • Calls invalidAsyncFunction for region and credentials providers, so that error will be thrown on provider await.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr mentioned this pull request Nov 25, 2020
Closed
@AllanZhengYP
Copy link
Contributor

Looks good. Although it mixes in a few model change like this one: https://github.com/aws/aws-sdk-js-v3/pull/1719/files#diff-07e0dd2a293b067508c4dafbf9853415671ac466bbe6a8a092006424af26092fR25. I will approve it but please remove the diffs from the commands and models.

@trivikr trivikr force-pushed the invalidAsyncFunction branch from 7c0968d to 115c767 Compare November 30, 2020 22:46
@codecov-io
Copy link

codecov-io commented Nov 30, 2020 •
edited
Loading

Codecov Report

Merging #1719 (2d76860) into master (de75f7e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1719      +/-   ##
==========================================
- Coverage   79.77%   79.77%   -0.01%     
==========================================
  Files         325      331       +6     
  Lines       12087    12586     +499     
  Branches     2553     2675     +122     
==========================================
+ Hits         9643    10041     +398     
- Misses       2444     2545     +101
Impacted Files Coverage Δ
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...col_tests/aws-restjson/commands/JsonMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlAttributesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc692e...2d76860. Read the comment docs.

@trivikr trivikr force-pushed the invalidAsyncFunction branch from 115c767 to a5ed281 Compare December 1, 2020 00:07
@trivikr trivikr force-pushed the invalidAsyncFunction branch from a5ed281 to 2d76860 Compare December 1, 2020 00:44
@trivikr
Copy link
Member Author

trivikr commented Dec 1, 2020

Although it mixes in a few model change like this one: https://github.com/aws/aws-sdk-js-v3/pull/1719/files#diff-07e0dd2a293b067508c4dafbf9853415671ac466bbe6a8a092006424af26092fR25

This was an issue with a bad merge in master, which was fixed in #1732

This PR is now rebased, and ready for review.

@trivikr trivikr merged commit c4c046e into aws:master Dec 1, 2020
@trivikr trivikr deleted the invalidAsyncFunction branch December 1, 2020 01:07
@trivikr trivikr mentioned this pull request Dec 16, 2020
Closed
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CognitoIdentityProviderClient incorrectly requires credentials.
3 participants
@trivikr @AllanZhengYP @codecov-io